carp checkers: add carp checker and make it work

Pond.package/CarpCheckExample.class/README.md

@@ -0,0 +1 @@
+I’m an example for checking Carp code.

Pond.package/CarpCheckExample.class/instance/failingCarpChecker.st

@@ -0,0 +1,6 @@
+examples
+failingCarpChecker
+	^ CarpChecker new
+		carp: '/Users/veitheller/.local/bin/carp';
+		dir: '/Users/veitheller/Documents/Code/Github/carp/Carp/';
+		file: '(def x a)'

Pond.package/CarpCheckExample.class/instance/succeedingCarpChecker.st

@@ -0,0 +1,6 @@
+examples
+succeedingCarpChecker
+	^ CarpChecker new
+		carp: '/Users/veitheller/.local/bin/carp';
+		dir: '/Users/veitheller/Documents/Code/Github/carp/Carp/';
+		file: '(def x 1)'

Pond.package/CarpCheckExample.class/properties.json

@@ -0,0 +1,11 @@
+{
+	"commentStamp" : "VeitHeller 12/16/2019 12:01",
+	"super" : "Object",
+	"category" : "Pond",
+	"classinstvars" : [ ],
+	"pools" : [ ],
+	"classvars" : [ ],
+	"instvars" : [ ],
+	"name" : "CarpCheckExample",
+	"type" : "normal"
+}

Pond.package/CarpCheckParser.class/README.md

@@ -0,0 +1 @@
+I’m a parser for the results of a Carp check.

Pond.package/CarpCheckParser.class/instance/parse..st

@@ -0,0 +1,7 @@
+parsing
+parse: aStream
+	| split contents |
+	contents := aStream upToEnd.
+	contents ifEmpty: [ ^ OrderedCollection new ].
+	split := contents splitOn: '\n'.
+	^ split collect: [ :s | self parseLine: s ]

Pond.package/CarpCheckParser.class/instance/parseLine..st

@@ -0,0 +1,13 @@
+parsing
+parseLine: aLine
+	| split res |
+	split := aLine splitOn: ':'.
+	split size == 3 ifFalse: [ 
+		^ CarpParseError new message: 'unparseable checker line: "' , aLine , '"'].
+	res := CarpParseError new
+		  file: (split at: 1);
+		  line: (split at: 2) asNumber.
+	split := (split at: 3) splitOn: ' '.
+	^ res
+		  column: (split at: 1) asNumber;
+		  message: (' ' join: split allButFirst)

Pond.package/CarpCheckParser.class/properties.json

@@ -0,0 +1,11 @@
+{
+	"commentStamp" : "VeitHeller 12/16/2019 11:18",
+	"super" : "Object",
+	"category" : "Pond",
+	"classinstvars" : [ ],
+	"pools" : [ ],
+	"classvars" : [ ],
+	"instvars" : [ ],
+	"name" : "CarpCheckParser",
+	"type" : "normal"
+}

Pond.package/CarpChecker.class/README.md

@@ -0,0 +1 @@
+I’m a special case of a Carp process for checking errors.

Pond.package/CarpChecker.class/instance/check.st

@@ -0,0 +1,9 @@
+checking
+check
+	| f |
+	f := FileReference newTempFilePrefix: 'checker' suffix: '.carp'.
+	f writeStreamDo: [:stream | stream nextPutAll: file].
+	proc arguments: {'--check' . f pathString }.
+	self run.
+	excepted ifNotNil: [ CarpError new messageText: excepted messageText ].
+	self died ifFalse: [ ^ CarpCheckParser new parse: proc stdoutStream ]

Pond.package/CarpChecker.class/instance/file..st

@@ -0,0 +1,3 @@
+checking
+file: aString
+	file := aString

Pond.package/CarpChecker.class/instance/file.st

@@ -0,0 +1,3 @@
+checking
+file
+	^ file

Pond.package/CarpChecker.class/instance/initialize.st

@@ -0,0 +1,5 @@
+checking
+initialize
+	proc := OSSUnixSubprocess new command: 'carp';
+				redirectStdout;
+				addAllEnvVariablesFromParentWithoutOverride

Pond.package/CarpChecker.class/instance/run.st

@@ -0,0 +1,4 @@
+checking
+run
+	[ [ proc run ] on: Error do: [ :err | excepted := err ] ] fork.
+	(Delay forMilliseconds: 500) wait.

Pond.package/CarpChecker.class/properties.json

@@ -0,0 +1,13 @@
+{
+	"commentStamp" : "VeitHeller 12/16/2019 10:34",
+	"super" : "CarpProcess",
+	"category" : "Pond",
+	"classinstvars" : [ ],
+	"pools" : [ ],
+	"classvars" : [ ],
+	"instvars" : [
+		"file"
+	],
+	"name" : "CarpChecker",
+	"type" : "normal"
+}

Pond.package/CarpError.class/properties.json

@@ -1,6 +1,6 @@
 {
 	"commentStamp" : "VeitHeller 12/14/2019 17:49",
-	"super" : "Exception",
+	"super" : "Error",
 	"category" : "Pond",
 	"classinstvars" : [ ],
 	"pools" : [ ],
@@ -9,6 +9,6 @@
 		"parent",
 		"error"
 	],
-	"name" : "CarpException",
+	"name" : "CarpError",
 	"type" : "normal"
 }

Pond.package/CarpParseError.class/README.md

@@ -0,0 +1 @@
+I represent a line of Carp checker output.

Pond.package/CarpParseError.class/instance/column..st

@@ -0,0 +1,3 @@
+accessing
+column: aNumber
+	column := aNumber

Pond.package/CarpParseError.class/instance/file..st

@@ -0,0 +1,3 @@
+accessing
+file: aString
+	file := aString

Pond.package/CarpParseError.class/instance/line..st

@@ -0,0 +1,3 @@
+accessing
+line: aNumber
+	line := aNumber

Pond.package/CarpParseError.class/instance/message..st

@@ -0,0 +1,3 @@
+accessing
+message: aString
+	message := aString

Pond.package/CarpParseError.class/instance/printOn..st

@@ -0,0 +1,13 @@
+accessing
+printOn: aStream
+	(file isNil or: [ line isNil or: column isNil ])
+		ifTrue: [ aStream nextPutAll: message ]
+		ifFalse: [
+			aStream nextPutAll: file.
+			aStream nextPutAll: ':'.
+			aStream nextPutAll: line asString.
+			aStream nextPutAll: ':'.
+			aStream nextPutAll: column asString.
+			aStream nextPutAll: ' '.
+			aStream nextPutAll: message.
+		]

Pond.package/CarpParseError.class/properties.json

@@ -0,0 +1,16 @@
+{
+	"commentStamp" : "VeitHeller 12/16/2019 11:26",
+	"super" : "Object",
+	"category" : "Pond",
+	"classinstvars" : [ ],
+	"pools" : [ ],
+	"classvars" : [ ],
+	"instvars" : [
+		"file",
+		"line",
+		"column",
+		"message"
+	],
+	"name" : "CarpParseError",
+	"type" : "normal"
+}

Pond.package/CarpProcess.class/class/carp..st

@@ -1,3 +1,3 @@
 as yet unclassified
 carp: aString
-  ^ self new setCarp: aString
+  ^ self new carp: aString

Pond.package/CarpProcess.class/instance/carp..st

@@ -0,0 +1,3 @@
+accessing
+carp: aString
+	proc command: aString

Pond.package/CarpProcess.class/instance/dir..st

@@ -0,0 +1,3 @@
+accessing
+dir: aString
+	proc environmentAt: 'CARP_DIR' put: aString

Pond.package/CarpProcess.class/instance/setCarp..st

@@ -1,3 +0,0 @@
-accessing
-setCarp: aString
-	proc command: aString

Pond.package/CarpProcess.class/instance/setDir..st

@@ -1,3 +0,0 @@
-accessing
-setDir: aString
-	proc environmentAt: 'CARP_DIR' put: aString

Pond.package/CarpProcess.class/properties.json

@@ -7,8 +7,6 @@
 	"classvars" : [ ],
 	"instvars" : [
 		"proc",
-		"out",
-		"in",
 		"excepted"
 	],
 	"name" : "CarpProcess",